Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest source-map-tests submodule #15

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

takikawa
Copy link
Contributor

@takikawa takikawa commented Oct 2, 2024

This PR both updates the tests submodule and improves validation logic to pass more tests.

Note: this depends on a test fix PR (tc39/source-map-tests#22) so it should get merged after that, at which point I'll update the submodule hash to the latest one.

Also adds validation logic to pass additional tests

  * Account for sourceRoot field when working with files
  * Check validation for file, sourceRoot
  * Make names field optional
  * Fix sourcesContent handling when wrong type
@takikawa takikawa force-pushed the update-submod-2024-10-02 branch from 1506d49 to a2853df Compare October 3, 2024 18:42
@takikawa
Copy link
Contributor Author

takikawa commented Oct 3, 2024

Updated the submodule hash, should be ready now

@jkup jkup self-requested a review October 3, 2024 19:09
Copy link
Owner

@jkup jkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkup jkup merged commit 6a60a6a into jkup:main Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants